Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 23 May 2011 18:50:47 +0000 (UTC)
From: "Steven Rowe (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1001130743.36907.1306176647331.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1322639952.35529.1306140707866.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (SOLR-2537) Refactor Solr modules
 structure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038114#comment-13038114 ] 

Steven Rowe edited comment on SOLR-2537 at 5/23/11 6:49 PM:
------------------------------------------------------------

bq. NetBeans doesn't recognize super.setUp().

In the .zip file containing your project, SolrConfigTest#setUp() *does* call super.setUp(), so I guess you removed it in your local version?  I've never used NetBeans.  By contrast, IntelliJ recognizes super.setUp() - since you're extending AbstractSolrTestCase, it should resolve to that class's setUp().  (BTW, did you know that the IntelliJ Community edition is free now?)

So I still don't understand exactly what the issue is with Solr Maven artifact consumption?

bq. Also, I'd solved my test problem w/o EmbeddedSolrServer which seems redundant to SolrTestCaseJ4, or is there an extra layer being tested in the EmbeddedSolrServer?

I don't understand any part of that sentence - can someone else chime in here if they understand it?


      was (Author: steve_rowe):
    bq. NetBeans doesn't recognize super.setUp().

In the .zip file containing your project, SolrConfigTest#setUp() *does* call super.setUp(), so I guess you removed it in your local version?  I've never used NetBeans.  By contrast, IntelliJ recognizes super.setUp() - since you're extending AbstractSolrTestCase, it should resolve to that class's setUp().  (BTW, did you know that the IntelliJ Community edition is free now?)

So I still don't understand exactly what the issue is with Solr Maven artifact consumption?

bq. Also, I'd solved my test problem w/o EmbeddedSolrServer which seems redundant to SolrTestCaseJ4, or is there an extra layer being tested in the EmbeddedSolrServer?

I don't understand any part of that sentence - can someone else chine in here if they understand it?

  
> Refactor Solr modules structure
> -------------------------------
>
>                 Key: SOLR-2537
>                 URL: https://issues.apache.org/jira/browse/SOLR-2537
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module is in the src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and Testframework makes it impossible to add a depenency on Solr-3.2-SNAPHOST (Solr Search Server) since it's packaged as a war, to import EmbeddedSolrServer.java, for example. It has been discussed on the mailing list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which depend on Solr Core and on the Test Framework. The org burden of that extra module, versus the ease of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will build without passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the TestFramework module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the packages under Solr Core. 
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr TestFramework declare it with <classifier>tests</classifier>, which packages only the tests, and the Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1] http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3c2D127F11DC79714E9B6A43AC9458147FBAD42EAD@suex07-mbx-03.ad.syr.edu%3e
> [2] http://maven.apache.org/guides/mini/guide-attached-tests.html
> [3] I've successfully used it before. https://code.google.com/p/memorizeasy/source/browse/MemoPlatform/persistenceui/pom.xml

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org