lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriele Kahlout (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2537) Refactor Solr modules structure
Date Mon, 23 May 2011 13:41:47 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037944#comment-13037944
] 

Gabriele Kahlout commented on SOLR-2537:
----------------------------------------

and those things in poms:
{code}
<parent>
<relativePath>../../pom.xml</relativePath>
  </parent>
{code}
{code}
   <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <configuration>
          <!-- Solrj tests are run from the solr-core build; -->
          <!-- otherwise there would be a cyclic dependency, -->
          <!-- since Solrj's tests depend on solr-core, and  -->
          <!-- solr-core depends on Solrj.                   -->
          <skipTests>true</skipTests>
        </configuration>
      </plugin>
{code}

> Refactor Solr modules structure
> -------------------------------
>
>                 Key: SOLR-2537
>                 URL: https://issues.apache.org/jira/browse/SOLR-2537
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Gabriele Kahlout
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module is in the
src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and Testframework
makes it impossible to add a depenency on Solr-3.2-SNAPHOST (Solr Search Server) since it's
packaged as a war, to import EmbeddedSolrServer.java, for example. It has been discussed on
the mailing list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which depend on
Solr Core and on the Test Framework. The org burden of that extra module, versus the ease
of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will build without
passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the TestFramework
module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the packages
under Solr Core. 
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr TestFramework declare
it with <classifier>tests</classifier>, which packages only the tests, and the
Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1] http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3c2D127F11DC79714E9B6A43AC9458147FBAD42EAD@suex07-mbx-03.ad.syr.edu%3e
> [2] http://maven.apache.org/guides/mini/guide-attached-tests.html
> [3] I've successfully used it before. https://code.google.com/p/memorizeasy/source/browse/MemoPlatform/persistenceui/pom.xml

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message