lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-2834) don't spawn thread statically in FSDirectory on Mac OS X
Date Wed, 25 May 2011 18:23:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039264#comment-13039264
] 

Uwe Schindler commented on LUCENE-2834:
---------------------------------------

Hi Mike,
from my point of view, this seems fine. We broke the MD5 already by forcing UTF-8 instead
of the default character set, so we can even change the whole hashing :-)

Collisions are not really an issue, this lock file naming is only used for lock files outside
index directory to make the chance of file name collisions less. Normal users will store lock
files in index directory, so this is not really an issue (lock prefix is null for this case).

Alternatively, to prevent collision, instead of hashing we could also collect all characters
that are valid for file names (remove all non-ASCII chars and '/'). But this could produce
a too-long filename.

> don't spawn thread statically in FSDirectory on Mac OS X
> --------------------------------------------------------
>
>                 Key: LUCENE-2834
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2834
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2834.patch, LUCENE-2834.patch, LUCENE-2834.patch, LUCENE-2834.patch
>
>
> on the Mac, creating the digester starts up a PKCS11 thread.
> I do not think threads should be created statically (I have this same issue with TimeLimitedCollector
and also FilterManager).
> Uwe discussed removing this md5 digester, I don't care if we remove it or not, just as
long as it doesn't create a thread,
> and just as long as it doesn't use the system default locale.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message