lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3106) commongrams filter calls incrementToken() after it returns false
Date Tue, 17 May 2011 02:41:47 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-3106:
--------------------------------

    Attachment: LUCENE-3106.patch

here's the obvious solution, but there might be a cleaner way to rewrite its loop...

> commongrams filter calls incrementToken() after it returns false
> ----------------------------------------------------------------
>
>                 Key: LUCENE-3106
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3106
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: Robert Muir
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3106.patch, LUCENE-3106_test.patch
>
>
> In LUCENE-3064, we beefed up MockTokenizer with assertions, and I started cutting over
some analysis tests to use MockTokenizer for better coverage.
> The commongrams tests fail, because they call incrementToken() after it already returns
false. 
> In general its my understanding consumers should not do this (and i know of a few tokenizers
that will actually throw exceptions if you do this, just like java iterators and such).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message