lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2530) Remove Noggit CharArr from FieldType
Date Tue, 24 May 2011 20:51:47 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038777#comment-13038777
] 

Robert Muir commented on SOLR-2530:
-----------------------------------

bq. I think this is ready though, all tests pass.

Looks good to me, there is still the one nocommit about interned fields but I don't know the
answer to that one either! The rest of the patch looks great, good to finally get rid of UTF16Result/incremental
api and to have a CharsRef.

> Remove Noggit CharArr from FieldType
> ------------------------------------
>
>                 Key: SOLR-2530
>                 URL: https://issues.apache.org/jira/browse/SOLR-2530
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>              Labels: api-change
>             Fix For: 4.0
>
>         Attachments: SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch,
SOLR-2530.patch
>
>
> FieldType#indexedToReadable(BytesRef, CharArr) uses a noggit dependency that also spreads
into ByteUtils. The uses of this method area all convert to String which makes this extra
reference and the dependency unnecessary. I refactored it to simply return string and removed
ByteUtils entirely. The only leftover from BytesUtils is a constant, i moved that one to Lucenes
UnicodeUtils. I will upload a patch in a second

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message