lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document
Date Mon, 30 May 2011 19:29:47 GMT


Michael McCandless commented on LUCENE-3099:

bq. I thought that 2883 was more about integrating fq, not a general module for value source
and docvalues that both grouping and fq can share. But I might have been mistaken.

Right LUCENE-2883 is about FQ, but I'm thinking we should simply "birth" the commons module
under LUCEEN-2883, meeting only the needs of FQ, initially.

After FQ is relatively done/stabilized, then we should look into grouping offering collectors
for all filed types, using the infrastructure from that common module, and extending the common
module at that time if there are needs of grouping not yet met, ie merging in the GroupValue,
GroupValueSource, GroupHolder from this patch.

> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>                 Key: LUCENE-3099
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override, then I think
we could refactor Solr over to the module, because it could do function queries and normal
queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own interesting
group values per document.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message