lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3147) MockDirectoryWrapper should track open file handles of IndexOutput too
Date Thu, 26 May 2011 13:21:47 GMT


Simon Willnauer commented on LUCENE-3147:

Shai I have a couple of comments

 * first good catch! :)
 * reenable the FIXME is awesome
 * in DefaultSegmentInfosWriter you might want to change the try / catch blocks to a simple
try / finally if (!succes) out.close(); for simplicity
 * in MockDirectoryWrapper#addFileHandle(io, name) you create an exception that always says
"Unclosed IndexInput" which should say IndexOutput if the handle is an index output. I think
this could be very confusing if you run into bugs there.


> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>                 Key: LUCENE-3147
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/test
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-3147.patch, LUCENE-3147.patch
> MockDirectoryWrapper currently tracks open file handles of IndexInput only. Therefore
IO files that are not closed do not fail our tests, which can then lead to test directories
fail to delete on Windows. We should make sure all open files are tracked and if they are
left open, fail the test. I'll attach a patch shortly.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message