lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Updated] (SOLR-2497) Move Solr to new NumericField stored field impl of LUCENE-3065
Date Wed, 04 May 2011 22:20:03 GMT


Uwe Schindler updated SOLR-2497:

    Attachment: SOLR-2497.patch

Patch applies to 3.2 branch only and needs the patch from LUCENE-3065 applied before:

Here a first step in cutover of Solr to NumericField. Most tests work, except:
- TestDistributedSearch, fails with a strange date problem - I have no idea what goes wrong
- TestMoreLikeThis: fails because the returned documents are different than expected. The
reason for this is simple: As TrieField's underlying Lucene fields now are NumericField, stringValue()
returns something (in contrast, solr's old fields returned null because they were binary).
This confuses maybe MoreLikeThis (needs maybe fixed in Lucene, I havent looked into the code).
Maybe we should simply exclude those fields or fix the test (I prefer latter one, because
the numerics should also taken into account).

The following changes had to be made:
- Cut over all places in Solr where Field instead of abstract Fieldable is used to Fieldable.
This affects some leftover parts in various components (calling Document.getField instead
of Document.getFieldable), but mainly SchemaField/FieldType: createField() now returns Fieldable
- TrieDateField code duplication was removed, all methods delegate to a wrapped TrieField.
There was also an inconsitency between TrieField and TrieDateField's toExternal(). This was
fixed to work correct (the date format was wrong, now it uses dateField.toExternal())

If somebody could help with the rest of the solr stuff and maybe test test test! Yonik? Ryan?
There may be some itches not covered by tests.

Thanks for help from Solr specialists (I am definitely not one, I am more afraid of the code
than I can help)!!!

> Move Solr to new NumericField stored field impl of LUCENE-3065
> --------------------------------------------------------------
>                 Key: SOLR-2497
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.2, 4.0
>         Attachments: SOLR-2497.patch
> This implements the changes to NumericField (LUCENE-3065) in Solr. TrieField & Co
would use NumericField for indexing and reading stored fields. To enable this some missing
changes in Solr's internals (Field -> Fieldable) need to be done. Also some backwards compatible
stored fields parsing is needed to read pre-3.2 indexes without reindexing (as the format
changed a little bit and Document.getFieldable returns NumericField instances now).

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message