lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3100) IW.commit() writes but fails to fsync the N.fnx file
Date Sun, 15 May 2011 06:24:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033652#comment-13033652
] 

Simon Willnauer commented on LUCENE-3100:
-----------------------------------------

man good catch! Since the fnx file is considered to be a real relative to the segments file
its not in the SIS#files if you don't specify commmit==true so it doesn't get synced with
other files during IW#prepareCommit. Phew, sneaky! I think we should sync that file upon successful
write explicitly in SIS - possibly simple change but big bang ey :)

> IW.commit() writes but fails to fsync the N.fnx file
> ----------------------------------------------------
>
>                 Key: LUCENE-3100
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3100
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>             Fix For: 4.0
>
>
> In making a unit test for NRTCachingDir (LUCENE-3092) I hit this surprising bug!
> Because the new N.fnx file is written at the "last minute" along with the segments file,
it's not included in the sis.files() that IW uses to figure out which files to sync.
> This bug means one could call IW.commit(), successfully, return, and then the machine
could crash and when it comes back up your index could be corrupted.
> We should hopefully first fix TestCrash so that it hits this bug (maybe it needs more/better
randomization?), then fix the bug....

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message