lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-2921) Now that we track the code version at the segment level, we can stop tracking it also in each file level
Date Tue, 24 May 2011 13:55:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038561#comment-13038561
] 

Shai Erera commented on LUCENE-2921:
------------------------------------

On this thread (http://lucene.markmail.org/thread/2puabohgbkgtbq7o) we discussed the option
of using Version in SI.getVersion(), and then we'll be able to easily compare segment versions.
Also, after we do this, StringHelper.versionComparator can be deleted.

> Now that we track the code version at the segment level, we can stop tracking it also
in each file level
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2921
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2921
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Shai Erera
>             Fix For: 3.2, 4.0
>
>
> Now that we track the code version that created the segment at the segment level, we
can stop tracking versions in each file. This has several major benefits:
> # Today the constant names that use to track versions are confusing - they do not state
since which version it applies to, and so it's harder to determine which formats we can stop
supporting when working on the next major release.
> # Those format numbers are usually negative, but in some cases positive (inconsistency)
-- we need to remember to increase it "one down" for the negative ones, which I always find
confusing.
> # It will remove the format tracking from all the *Writers, and the *Reader will receive
the code format (String) and work w/ the appropriate constant (e.g. Constants.LUCENE_30).
Centralizing version tracking to SegmentInfo is an advantage IMO.
> It's not urgent that we do it for 3.1 (though it requires an index format change), because
starting from 3.1 all segments track their version number anyway (or migrated to track it),
so we can safely release it in follow-on 3x release.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message