lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Rutherglen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2193) Re-architect Update Handler
Date Tue, 31 May 2011 03:54:47 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041399#comment-13041399
] 

Jason Rutherglen commented on SOLR-2193:
----------------------------------------

bq. IndexWriter writer =((DirectUpdateHandler2)core.getUpdateHandler()).getIndexWriterProvider().getIndexWriter();

Why isn't IW a part of SolrCore? It's the main class running the show. How
can there be a Solr core without an IW? I think IW never gets closed until
the SolrCore is closed. The next move would be to place all of the caches
at the segment level. 

It's been clear for quite a while that you folks at "Lucid" are trying to
protect your golden goose, eg, Solr from changing much unless dictated by
your staff or a paying customer. I think in politics those are called
bribes? Hence a large part of the recent fracas regarding modularizing the
goose, whose 'resolution' has resulted in no changes.

It's astonishing the changes that are OK for Solr by some people, that are
no OK from others. This is not a meritocracy. If you insist on driving,
you should incorporate some of the feedback given. Solr was hacked
together from the beginning and this is yet another ugly retrofit that is
being steamrolled in. If you're confident in your abilities you're
confident enough to make major changes. I've never seen that on the Solr
side of the Lucene project.

bq. I remember that issue - I tried to make some comments to help you out with it 

No there was push back on something silly and simple, eg, getting the IW
from the UpdateHandler, just as you have done here. What is the point in
contributing when they are blocked for no reason?

bq. SOLR-1155

What happened to this poor guys patch?  Nothing.

> Re-architect Update Handler
> ---------------------------
>
>                 Key: SOLR-2193
>                 URL: https://issues.apache.org/jira/browse/SOLR-2193
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.0
>
>         Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch,
SOLR-2193.patch
>
>
> The update handler needs an overhaul.
> A few goals I think we might want to look at:
> 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like UpdateHandler,
DefaultUpdateHandler
> 2. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what
we now do with special casing:
> if (directupdatehandler2)
>   success
>  else
>   failish
> 3. Stop closing the IndexWriter and start using commit (still lazy IW init though).
> 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
> 5. Keep NRT support in mind.
> 6. Keep microsharding in mind (maintain logical index as multiple physical indexes)
> 7. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message