lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3143) SegmentMerger should assert .del and .s* files are not passed to createCompoundFile
Date Wed, 25 May 2011 13:19:47 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shai Erera updated LUCENE-3143:
-------------------------------

    Attachment: LUCENE-3143.patch

Patch against 3x, adds asserts to SM + test to ensure they are not allowed. All core tests
pass.

> SegmentMerger should assert .del and .s* files are not passed to createCompoundFile
> -----------------------------------------------------------------------------------
>
>                 Key: LUCENE-3143
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3143
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3143.patch
>
>
> Spinoff from LUCENE-3126. SegmentMerger.createCompoundFile does not document that it
should not receive files that are not included in the .cfs, such as .del and .s* (separate
norms). Today, that method is called from code which ensures that, but we should:
> # Add some documentation to clarify that.
> # Add some asserts so that if a test (or other code, running w/ -ea) does that, we catch
it.
> Will post a patch soon

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message