lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <>
Subject [jira] [Commented] (SOLR-2193) Re-architect Update Handler
Date Mon, 30 May 2011 20:29:47 GMT


Mark Miller commented on SOLR-2193:

bq. I think it'll be easier to add what's needed for this patch into Lucene rather than retrofit

This makes no sense :) See my above comment.

bq. Ugly Solr style code?!

This is simply to detect the case where the update handler was changed on reload - not something
we even necessarily have to support - but a case I did consider. If you can suggest better
code to handle such a case, please do.

bq. The commit in X time can be simple contrib class for Lucene. It doesn't need to be Solr

Moving the location of the auto commit code would be a very different issue. Not one that
makes sense to me right now either.

bq. Anyways I tried to do this 2 years ago for NRT, there was pushback just get the IndexWriter
like the above code from the update handler. <political>Wow</political>

I remember that issue - I tried to make some comments to help you out with it - you never
managed to get it very far if memory serves though - so now I'm taking my own crack at it,
along with addressing a few other pet peeves I have.

> Re-architect Update Handler
> ---------------------------
>                 Key: SOLR-2193
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.0
>         Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch
> The update handler needs an overhaul.
> A few goals I think we might want to look at:
> 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like UpdateHandler,
> 2. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what
we now do with special casing:
> if (directupdatehandler2)
>   success
>  else
>   failish
> 3. Stop closing the IndexWriter and start using commit (still lazy IW init though).
> 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
> 5. Keep NRT support in mind.
> 6. Keep microsharding in mind (maintain logical index as multiple physical indexes)
> 7. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message