lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2191) Change SolrException cstrs that take Throwable to default to alreadyLogged=false
Date Mon, 02 May 2011 23:22:03 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027915#comment-13027915
] 

Hoss Man commented on SOLR-2191:
--------------------------------

Is anyone else interested in entertaining the notion that the "alreadyLogged" concept is more
trouble then it's worth and we should just rip the whole damn thing out? (deprecate logOnce,
etc...)

is there such a thing as logging an exception "too much"? and if there is, couldn't we fix
those code paths to be less chatty? 

> Change SolrException cstrs that take Throwable to default to alreadyLogged=false
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-2191
>                 URL: https://issues.apache.org/jira/browse/SOLR-2191
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>             Fix For: Next
>
>         Attachments: SOLR-2191.patch
>
>
> Because of misuse, many exceptions are now not logged at all - can be painful when doing
dev. I think we should flip this setting and work at removing any double logging - losing
logging is worse (and it almost looks like we lose more logging than we would get in double
logging) - and bad solrexception/logging patterns are proliferating.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message