lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-2834) don't spawn thread statically in FSDirectory on Mac OS X
Date Sun, 22 May 2011 13:31:47 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-2834:
---------------------------------------

    Attachment: LUCENE-2834.patch


New patch, just modernized to current trunk, removed special-case
checking of OS X's PKCS11 thread (since we no longer serialize), and
throw new RE() in those "impossible" catch clauses.

I think it's important we poach our own MD5 impl because 1) Java's
crypto lib is not guaranteed to impl MD5, 2) using MD5 has hidden
costs (spawning this thread in OS X), and 3) no longer using
SecureRandom just to create our temp test dirs makes great sense
(we've had crazy problems w/ SecureRandom in the past).

I think it's ready to commit.  Uwe do you still have such strong
objections?


> don't spawn thread statically in FSDirectory on Mac OS X
> --------------------------------------------------------
>
>                 Key: LUCENE-2834
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2834
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-2834.patch, LUCENE-2834.patch, LUCENE-2834.patch
>
>
> on the Mac, creating the digester starts up a PKCS11 thread.
> I do not think threads should be created statically (I have this same issue with TimeLimitedCollector
and also FilterManager).
> Uwe discussed removing this md5 digester, I don't care if we remove it or not, just as
long as it doesn't create a thread,
> and just as long as it doesn't use the system default locale.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message