lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3057) LuceneTestCase#newFSDirectoryImpl misses to set LockFactory if ctor call throws exception
Date Mon, 02 May 2011 07:30:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027570#comment-13027570
] 

Simon Willnauer commented on LUCENE-3057:
-----------------------------------------

bq. Hi Simon, I think you meant to set the lockfactory in the finally block?
thanks robert for catching this I removed the return statement in revision 1098375.

Backported to 3.x in revision 1098505

> LuceneTestCase#newFSDirectoryImpl misses to set LockFactory if ctor call throws exception
> -----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3057
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3057
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3057.patch, LUCENE-3057_bug.patch
>
>
> selckin reported on IRC that if you run ant test -Dtestcase=TestLockFactory -Dtestmethod=testNativeFSLockFactoryPrefix
-Dtests.directory=FSDirectory the test fails. Since FSDirectory is an abstract class it can
not be instantiated so our code falls back to FSDirector.open. yet we miss to set the given
lockFactory though.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message