lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2533) Improve API of ValueSource & FunctionQuery SortField weighting
Date Sun, 22 May 2011 10:17:47 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037553#comment-13037553
] 

Michael McCandless commented on SOLR-2533:
------------------------------------------

OK, I agree: let's not make this strongly typed.  So, this 'weighting' is more like Query.rewrite
than Query.weight, right?

Ie, if it needs to, it returns a new Query that "compiled in" something about the top searcher
it was passed.  If it doesn't need to, it returns itself?

Patch looks great Chris!  Except I wonder if we should rename "weight" to "rewrite", or something
else... (compile?  compileSearcher?)?

> Improve API of ValueSource & FunctionQuery SortField weighting
> --------------------------------------------------------------
>
>                 Key: SOLR-2533
>                 URL: https://issues.apache.org/jira/browse/SOLR-2533
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Chris Male
>         Attachments: SOLR-2533.patch
>
>
> Started from LUCENE-2883: Support for sorting by ValueSource and FunctionQueries is done
through ValueSource#getSort and the ValueSourceSortField.  In order to support VSs containing
other Queries, its necessary to allow the Querys to be weighted by an IndexSearcher.  Currently
this is handled by having ValueSourceSortField implement SolrSortField.  In Solr's SolrIndexSearcher,
SortFields implementing SolrSortField are then weighted before the Sort is used.
> Sorting by FunctionQuery and ValueSource are invaluable and will become available to
all Lucene users in LUCENE-2883.  But in order to do so, we need to remove the coupling of
this functionality to Solr, and make it more standard.
> Any and all thoughts about how to do this are appreciated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message