lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Rutherglen (JIRA)" <>
Subject [jira] [Commented] (SOLR-2193) Re-architect Update Handler
Date Mon, 30 May 2011 20:27:48 GMT


Jason Rutherglen commented on SOLR-2193:

bq. This patch certainly won't complete the NRT work needed

Mark, I was reading this comment.  

bq. You are questioning my whole patch

I think it'll be easier to add what's needed for this patch into Lucene rather than retrofit
Solr.  I mentioned this a while back however there was pushback on re-architecting Solr. 
Making everything per-segment would be much more productive than allowing NRT at this stage.
 Ah, I think you're simply trying to avoid the stop the world Solr has right now?  If so that
should be more prevalent in the Jira.  

bq. IndexWriter writer = ((DirectUpdateHandler2)core.getUpdateHandler()).getIndexWriterProvider().getIndexWriter();

Ugly Solr style code?!

The commit in X time can be simple contrib class for Lucene.  It doesn't need to be Solr specific.

Anyways I tried to do this 2 years ago for NRT, there was pushback just get the IndexWriter
like the above code from the update handler.  <political>Wow</political>

> Re-architect Update Handler
> ---------------------------
>                 Key: SOLR-2193
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.0
>         Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch
> The update handler needs an overhaul.
> A few goals I think we might want to look at:
> 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like UpdateHandler,
> 2. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what
we now do with special casing:
> if (directupdatehandler2)
>   success
>  else
>   failish
> 3. Stop closing the IndexWriter and start using commit (still lazy IW init though).
> 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
> 5. Keep NRT support in mind.
> 6. Keep microsharding in mind (maintain logical index as multiple physical indexes)
> 7. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message