lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2543) Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
Date Fri, 27 May 2011 20:36:47 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040421#comment-13040421
] 

Michael McCandless commented on SOLR-2543:
------------------------------------------

OK got to the bottom of this... it was confounding:

  * TestIndexSearcher was buggy: it had a devious bug that caused it to
    open more searchers than it closed.

  * TestIndexSearcher did not catch this (SOLR-2552 fixes that)

  * Another test (SpellPossibilityIteratorTest) falsely took the fall
    for not closing all searchers, because it happens to run in the
    same JVM.

  * The logic that tests for not closing all searchers is fragile
    (each test is not guaranteed to only count its own opened
    searchers).  SOLR-2552 should also fix this...

Finally, it turns out the TestIndexSearcher bug had already been fixed
on trunk... please backport fixes from trunk to 3.x when possible,
especially test and test infra fixes!


> Backport the trunk's version of SolrTestCaseJ4 to 3x branch.
> ------------------------------------------------------------
>
>                 Key: SOLR-2543
>                 URL: https://issues.apache.org/jira/browse/SOLR-2543
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Assignee: Martijn van Groningen
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: SOLR-2543.patch
>
>
> The trunk version has some methods / utilities to provide random testing.
> SOLR-2524 has a back ported random test from trunk, that needs this infrastructure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message