lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document
Date Mon, 30 May 2011 19:17:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041239#comment-13041239
] 

Martijn van Groningen commented on LUCENE-3099:
-----------------------------------------------

bq. I think we can take this up under LUCENE-2883?
I thought that 2883 was more about integrating fq, not a general module for value source and
docvalues that both grouping and fq can share. But I might have been mistaken.

bq. Should we name it TermAllGroupsCollector
+1 I'll rename it

{quoto}
Maybe, instead, we can have only retrieveDocGroup? And if it returns
null that means the group for this doc isn't being collected? Then we
don't double the ord lookup for TermSecondPass.
{quote}
That seems reasonable to me. That also saves a key lookup for the TermSecondPassGroupingCollector.

> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-3099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3099
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch
>
>
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override, then I think
we could refactor Solr over to the module, because it could do function queries and normal
queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own interesting
group values per document.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message