lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3070) Enable DocValues by default for every Codec
Date Thu, 05 May 2011 08:32:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029233#comment-13029233
] 

Simon Willnauer commented on LUCENE-3070:
-----------------------------------------

Robert patch looks great!

some comments:
 * the simpletext nocommit should be a TODO IMO
 * for the preflex problem I think we need to add some infrastructure to add tests for 4.0
features somehow I will think about this
 * one problem we are having here is that our current implementation is somewhat wasteful.
Currently on flush we pull a FieldsConsumer for every codec used in the indexing session (per
DWPT) regardless if this field is indexed. so we are creating some unneeded files if you use
one field for docvalues only. The other thing is that we need to somehow reset the FieldInfo#hasDocValues
"flag" on an error when we are hitting non-aborting exceptions during indexing before we can
actually create the corresponding consumer. That is something we should address in a spin-off
issue I think.

overall I think you should commit the current state and we work from here!


> Enable DocValues by default for every Codec
> -------------------------------------------
>
>                 Key: LUCENE-3070
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3070
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Index
>    Affects Versions: CSF branch
>            Reporter: Simon Willnauer
>             Fix For: CSF branch
>
>         Attachments: LUCENE-3070.patch
>
>
> Currently DocValues are enable with a wrapper Codec so each codec which needs DocValues
must be wrapped by DocValuesCodec. The DocValues writer and reader should be moved to Codec
to be enabled by default.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message