lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3065) NumericField should be stored in binary format in index (matching Solr's format)
Date Thu, 05 May 2011 16:21:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029412#comment-13029412
] 

Uwe Schindler commented on LUCENE-3065:
---------------------------------------

Patch against 3.x.

I moved the to/from byte[] methods from Solr's TrieField into Lucene's NumericUtils, and fixed
FieldsWriter/Reader to use free bits in the field's flags to know if the field is Numeric,
and which type.

I added a random test case to verify we now get the right NumericField back, when we stored
NumericField during indexing.

Old indices are handled fine (you'll get a String-ified Field back like you did before).

Spookily, nothing failed in Solr... I assume there's somewhere in Solr that must now be fixed
to handle the fact that a field can come back as NumericField?  Anyone know where...?)


> NumericField should be stored in binary format in index (matching Solr's format)
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-3065
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3065
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3065.patch, LUCENE-3065.patch, LUCENE-3065.patch, LUCENE-3065.patch,
LUCENE-3065.patch, LUCENE-3065.patch, LUCENE-3065.patch
>
>
> (Spinoff of LUCENE-3001)
> Today when writing stored fields we don't record that the field was a NumericField, and
so at IndexReader time you get back an "ordinary" Field and your number has turned into a
string.  See https://issues.apache.org/jira/browse/LUCENE-1701?focusedCommentId=12721972&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12721972
> We have spare bits already in stored fields, so, we should use one to record that the
field is numeric, and then encode the numeric field in Solr's more-compact binary format.
> A nice side-effect is we fix the long standing issue that you don't get a NumericField
back when loading your document.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message