lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3061) Open IndexWriter API to allow custom MergeScheduler implementation
Date Mon, 02 May 2011 11:51:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027627#comment-13027627
] 

Shai Erera commented on LUCENE-3061:
------------------------------------

I don't think they are experimental though -- they exist for ages. We only made them public.

I get your point - you don't think we should commit to this API signature, but IMO we should
-- if MS is a valid extension point by applications, we must support this API, otherwise MS
cannot be extended at all. Also, getNextMerge() jdoc specifies "Expert: the MergeScheeduler
calls this method ..." - this kind of makes this API public long time ago, only it wasn't.

> Open IndexWriter API to allow custom MergeScheduler implementation
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3061
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3061
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3061.patch, LUCENE-3061.patch
>
>
> IndexWriter's getNextMerge() and merge(OneMerge) are package-private, which makes it
impossible for someone to implement his own MergeScheduler. We should open up these API, as
well as any other that can be useful for custom MS implementations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message