lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3147) MockDirectoryWrapper should track open file handles of IndexOutput too
Date Sun, 29 May 2011 02:57:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040727#comment-13040727
] 

Simon Willnauer commented on LUCENE-3147:
-----------------------------------------

bq. I'm still hitting an intermittent fail:
I fixed the last failure mike reported on the branch. If we abort a flushAll and a excp. is
thrown in the abort method we were not closing the remaining dwpt in the queues.

bq. But: why do we ever "abort" a full flush...? It looks like it happens because one of the
DWPTs hits an exc while flushing...?

I think this is the way to go here. if one DWPT can not flush why would be continue flushing
the remaining ones. You will need to call rollback anyway or reindex all documents since the
last commit. Its unnecessary to flush those DWPT since we are already lost the failed segment.

> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-3147
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3147
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/test
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch,
LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch, LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only. Therefore
IO files that are not closed do not fail our tests, which can then lead to test directories
fail to delete on Windows. We should make sure all open files are tracked and if they are
left open, fail the test. I'll attach a patch shortly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message