lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3099) Grouping module should allow subclasses to set the group key per document
Date Mon, 30 May 2011 18:51:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041228#comment-13041228
] 

Michael McCandless commented on LUCENE-3099:
--------------------------------------------


bq. Should we rename all abstract collectors to Abstract*? To make it clear that these classes
are abstract.

+1

bq. You think that we already should open a new issue for this?

I think we can take this up under LUCENE-2883?  There's already an
initial patch there, starting to factor out Mutable*...

Should we name it TermAllGroupsCollector (instead of Terms...)?  Or,
fix the others to be TermsFirst/SecondPassCollector?

bq. I noticed that FirstPassGroupingCollector and SecondPassGroupingCollector still has groupField
as field and constructor argument. So I moved this to TermsFirstPassGroupingCollector and
TermSecondPassGroupingCollector

Ahh, excellent -- these abstract base classes don't need to know it's
a feild we are grouping on.

bq. When working with fqs the slot is not practical, since there is no ords (like DocTermsIndex).

OK I agree.

Maybe, instead, we can have only retrieveDocGroup?  And if it returns
null that means the group for this doc isn't being collected?  Then we
don't double the ord lookup for TermSecondPass.


> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-3099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3099
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch
>
>
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override, then I think
we could refactor Solr over to the module, because it could do function queries and normal
queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own interesting
group values per document.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message