lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2497) Move Solr to new NumericField stored field impl of LUCENE-3065
Date Fri, 06 May 2011 05:59:03 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029763#comment-13029763
] 

Uwe Schindler commented on SOLR-2497:
-------------------------------------

Hi Chris,
you are the best! Only your soliution was not correct, the change must be made in TrieField
(wrappedField). The problem here was a bug in the original code (as of Lucene 1.4 / 3.1) [the
same I already mentioned above]: If you created in your Schema a TrieField with type attribute
set to DATE, it behaved differently than if you used a TrieDateField (same issue had been
fixed before in toExternal:

{quote}
TrieDateField code duplication was removed, all methods delegate to a wrapped TrieField. There
was also an inconsistency between TrieField and TrieDateField's toExternal(). This was fixed
to work correct (the date format was wrong, now it uses dateField.toExternal())
{quote}

The correct fix is to make TrieField.indexedToReadable call DateField's toExternal internally
(like toExternal now does).

> Move Solr to new NumericField stored field impl of LUCENE-3065
> --------------------------------------------------------------
>
>                 Key: SOLR-2497
>                 URL: https://issues.apache.org/jira/browse/SOLR-2497
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2497.patch, SOLR-2497.patch, SOLR-2497.patch
>
>
> This implements the changes to NumericField (LUCENE-3065) in Solr. TrieField & Co
would use NumericField for indexing and reading stored fields. To enable this some missing
changes in Solr's internals (Field -> Fieldable) need to be done. Also some backwards compatible
stored fields parsing is needed to read pre-3.2 indexes without reindexing (as the format
changed a little bit and Document.getFieldable returns NumericField instances now).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message