lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2484) Make SynonymFilterFactory more extendable
Date Mon, 02 May 2011 23:28:03 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027920#comment-13027920
] 

Steven Rowe commented on SOLR-2484:
-----------------------------------

Ryan,

[Jenkins|https://builds.apache.org/hudson/job/Lucene-Solr-tests-only-trunk/7666/] is unhappy
with {{import visad.UnimplementedException}}:

{noformat}
compileTests:
    [mkdir] Created dir: /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-trunk/checkout/solr/build/tests
    [javac] Compiling 264 source files to /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-trunk/checkout/solr/build/tests
    [javac] /usr/home/hudson/hudson-slave/workspace/Lucene-Solr-tests-only-trunk/checkout/solr/src/test/org/apache/solr/analysis/TestSynonymMap.java:32:
package visad does not exist
    [javac] import visad.UnimplementedException;
    [javac]             ^
{noformat}

> Make SynonymFilterFactory more extendable
> -----------------------------------------
>
>                 Key: SOLR-2484
>                 URL: https://issues.apache.org/jira/browse/SOLR-2484
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Trivial
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2484-SynonymFilterFactory.patch
>
>
> As is, reading rules from the ResourceLoader is baked into inform(ResourceLoader loader).
 It would be nice to be able to load custom rules w/o needing to rewrite the whole thing.
 This issue changes two things:
> # Changes List<String> to Iterable<String> because we don't really need a
list
> # adds protected Iterable<String> loadRules( String synonyms, ResourceLoader loader
) -- so subclasses could fill their own

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message