lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <>
Subject [jira] [Commented] (SOLR-2193) Re-architect Update Handler
Date Tue, 31 May 2011 04:59:47 GMT


Mark Miller commented on SOLR-2193:

Plus this is a holiday :( Do I really have to take unfounded lucid crap even in my free time?

Well, I'm game. I've pulled out my bottle of wine, and I'm ready to answer your questions:

bq. Why isn't IW a part of SolrCore?...

I leave this as an exercise for the reader.

bq. I think in politics those are called bribes? 

I want it always to be known - that I will in fact take bribes. In fact, I'd like to take
my first one any time anyone is willing to pay me. As this is a legally gray area, you will
have to understand that I cannot place any guarantees on my work. Also, I'm currently only
accepting bitcoin.

bq. If you insist on driving, you should incorporate some of the feedback given.

I don't need to drive. I love it when others drives. Some people are such good drivers! Trust
me - I was never one to jump to drive. I can be fairly absent minded. My friends often preferred
to drive. But by golly, there where some people even I wouldn't drive with...sometimes cause
I was never needing to go anywhere when they where driving, and other times cause they where
scary drivers!

bq.  If you're confident in your abilities you're confident enough to make major changes.
I've never seen that on the Solr side of the Lucene project.

I'm sorry! I will try harder! My abilities are not insane. But I think they are good. I've
never been great with self rating, but I think I'm a solid above average. I'm even better
at 4v4 Warcraft3, all archer strategy. If not for Korea, that is how I'd make my money. It
would be way easier to accumulate bitcoin that way.

bq. Solr was hacked together from the beginning and this is yet another ugly retrofit that
is being steamrolled in.

Steamrolled? You hurt me...I only just above I don't won't to steam roll this issue that I
am working in my free time of my own volition? My you are a fun guy :) 

No there was push back on something silly and simple, eg, getting the IW
from the UpdateHandler, just as you have done here. What is the point in
contributing when they are blocked for no reason?

Jason, that is in test code :) My approach is plenty different from what you are up to :)

bq. What happened to this poor guys patch? Nothing.

I had never seen this guys patch. It's not my job to jump on anyones patch if I did. Since
I have started my rearchitect issue, I have seen a couple issues out there that do a small
piece of what I am up to. I have looked at a couple, and they did not work how I wanted. You
can try it a different way. Honestly, if you write some code that I like, I will commit it
for you. But I will only commit what I'm comfortable with. Lucky for you there are a bunch
of us. Many not from Lucid. All you gotto do is convince one of them to take on your issue
or tackle your code.

Personally, I make my contributions lately out of my own time and will. If it bothers you
so much, I'll be happy to hold off - those that voted for this issue can wait for someone
else to fix this at the "lucene level like twitter".

> Re-architect Update Handler
> ---------------------------
>                 Key: SOLR-2193
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.0
>         Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch,
> The update handler needs an overhaul.
> A few goals I think we might want to look at:
> 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like UpdateHandler,
> 2. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what
we now do with special casing:
> if (directupdatehandler2)
>   success
>  else
>   failish
> 3. Stop closing the IndexWriter and start using commit (still lazy IW init though).
> 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
> 5. Keep NRT support in mind.
> 6. Keep microsharding in mind (maintain logical index as multiple physical indexes)
> 7. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message