lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3147) MockDirectoryWrapper should track open file handles of IndexOutput too
Date Thu, 26 May 2011 12:54:47 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shai Erera updated LUCENE-3147:
-------------------------------

    Attachment: LUCENE-3147.patch

Patch resolves another leaked file handle.

Additionally, TestIndexWriterExceptions.testOptimizeExceptions() fails w/ some leftovers.
I modified it to use SerialMergeScheduler so that it's easier to debug, and it fails on _e_0.doc
left open. Is that the DocValues file (not sure if it was landed on trunk or not).

You can reproduce with:
ant test -Dtestcase=TestIndexWriterExceptions -Dtestmethod=testOptimizeExceptions -Dtests.seed=-226675704182511370:3818287653643995169

Debug-tracing what's happening after the IOE is thrown does not reveal any obvious leak. I
can continue debugging it later, but if someone can spot it quicker, that'll be great.

Also, shall we perhaps commit the changes to MockDirWrapper + II/IOWrappers and let Hudson
hunt down the failures for us?

> MockDirectoryWrapper should track open file handles of IndexOutput too
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-3147
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3147
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: general/test
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3147.patch, LUCENE-3147.patch
>
>
> MockDirectoryWrapper currently tracks open file handles of IndexInput only. Therefore
IO files that are not closed do not fail our tests, which can then lead to test directories
fail to delete on Windows. We should make sure all open files are tracked and if they are
left open, fail the test. I'll attach a patch shortly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message