lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-1942) Ability to select codec per field
Date Thu, 19 May 2011 13:29:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036177#comment-13036177
] 

Robert Muir commented on SOLR-1942:
-----------------------------------

Hi Simon, 

after reviewing the patch I have some concerns about CodecProvider. I think its a little bit
confusing how the CodecProvider/CoreCodecProvider hierarchy works today, and a bit dangerous
how we delegate over this class.

For example, if we add a new method to CodecProvider, we need to be sure we add the 'delegation'
here every time or stuff will start acting strange.

For this reason, I wonder if CodecProvider should be an interface: the simple implementation
we have in lucene is a hashmap, but Solr uses fieldType lookup. This would parallel how SimilarityProvider
works.

If we want to do this, I think we should open a separate issue... in fact I'm not even sure
it should block this issue since in my opinion its a shame you cannot manipulate codecs in
Solr right now... but I just wanted to bring it up here.


> Ability to select codec per field
> ---------------------------------
>
>                 Key: SOLR-1942
>                 URL: https://issues.apache.org/jira/browse/SOLR-1942
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Yonik Seeley
>            Assignee: Grant Ingersoll
>             Fix For: 4.0
>
>         Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch,
SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch
>
>
> We should use PerFieldCodecWrapper to allow users to select the codec per-field.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message