lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2193) Re-architect Update Handler
Date Mon, 30 May 2011 19:58:49 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041261#comment-13041261
] 

Mark Miller commented on SOLR-2193:
-----------------------------------

Reporting the current state regarding original goals:

bq. 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like UpdateHandler,
DefaultUpdateHandler

I want to do this, but it's just easier to handle after the first commit.

{quote} 2. Expose the SolrIndexWriter in the api or add the proper abstractions to get done
what we now do with special casing:
if (directupdatehandler2)
success
else
failish {quote}

There is no need for this anymore.

bq. 3. Stop closing the IndexWriter and start using commit (still lazy IW init though).

This is done.

bq. 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.

This is done.

bq. 5. Keep NRT support in mind.

Always ;) This patch certainly won't complete the NRT work needed, but it's a large start,
and a huge step forward for Solr. Much of what is left to do is in this area though.

bq. 6. Keep microsharding in mind (maintain logical index as multiple physical indexes)

Have not really addressed anything here - don't think I hurt anything either though. Worth
considering the new IndexWriterProvider and how it might relate to this though.

{quote}7. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.{quote}

I've made an attempt at this with the IndexWriterProvider and some simple ref counting that
could use a once over. This changes how you should reload a Solrcore - rather than just opening
a new one and closing the old one, you want to call a method on the SolrCore itself and get
the new SolrCore.

More to come. I've updated the patch to trunk as well - will attach shortly.

> Re-architect Update Handler
> ---------------------------
>
>                 Key: SOLR-2193
>                 URL: https://issues.apache.org/jira/browse/SOLR-2193
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.0
>
>         Attachments: SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch, SOLR-2193.patch
>
>
> The update handler needs an overhaul.
> A few goals I think we might want to look at:
> 1. Cleanup - drop DirectUpdateHandler(2) line - move to something like UpdateHandler,
DefaultUpdateHandler
> 2. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what
we now do with special casing:
> if (directupdatehandler2)
>   success
>  else
>   failish
> 3. Stop closing the IndexWriter and start using commit (still lazy IW init though).
> 4. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
> 5. Keep NRT support in mind.
> 6. Keep microsharding in mind (maintain logical index as multiple physical indexes)
> 7. Address the current issues we face because multiple original/'reloaded' cores can
have a different IndexWriter on the same index.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message