lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3080) cutover highlighter to BytesRef
Date Sat, 07 May 2011 12:36:03 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030339#comment-13030339
] 

Uwe Schindler commented on LUCENE-3080:
---------------------------------------

In the past this was not an issue, because stored numeric fields in Solr were only binary,
but now they are consumed by the highlighter component.

If we dont fix highlighter I have no problem. We should add some checks in highlighter to
prevent NumericFields from beeing highlighted (e.g. if the TokenStream does not support CTA,
it should stop highlighting). The above hack was just faster to implement in Solr to not slow
down merging (because index formats from 3.x and trunk are incompatible now, so trunk needs
to be committed ASAP).

This is why I opened this issue. Just to record that its a little bit inconsistent. But of
course your response is true, it may make more problems.

> cutover highlighter to BytesRef
> -------------------------------
>
>                 Key: LUCENE-3080
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3080
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/highlighter
>            Reporter: Michael McCandless
>
> Highlighter still uses char[] terms (consumes tokens from the analyzer as char[] not
as BytesRef), which is causing problems for merging SOLR-2497 to trunk.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message