Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A72441FE7 for ; Tue, 26 Apr 2011 02:11:45 +0000 (UTC) Received: (qmail 44257 invoked by uid 500); 26 Apr 2011 02:11:44 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 44189 invoked by uid 500); 26 Apr 2011 02:11:44 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 44182 invoked by uid 99); 26 Apr 2011 02:11:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2011 02:11:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2011 02:11:42 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 76B09B3D43 for ; Tue, 26 Apr 2011 02:11:03 +0000 (UTC) Date: Tue, 26 Apr 2011 02:11:03 +0000 (UTC) From: "Koji Sekiguchi (JIRA)" To: dev@lucene.apache.org Message-ID: <612965785.1204.1303783863482.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1795168333.12334.1299192817077.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (LUCENE-2949) FastVectorHighlighter FieldTermStack could likely benefit from using TermVectorMapper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Sekiguchi updated LUCENE-2949: ----------------------------------- Attachment: LUCENE-2949.patch A first draft patch. All FVH tests pass. As it is my first experience of TermVectorMapper, feedback would be appreciated. For example, I left setExpectations() empty, but I'm not sure it is correct. > FastVectorHighlighter FieldTermStack could likely benefit from using TermVectorMapper > ------------------------------------------------------------------------------------- > > Key: LUCENE-2949 > URL: https://issues.apache.org/jira/browse/LUCENE-2949 > Project: Lucene - Java > Issue Type: Improvement > Affects Versions: 3.0.3, 4.0 > Reporter: Grant Ingersoll > Assignee: Koji Sekiguchi > Priority: Minor > Labels: FastVectorHighlighter, Highlighter > Fix For: 3.2, 4.0 > > Attachments: LUCENE-2949.patch > > > Based on my reading of the FieldTermStack constructor that loads the vector from disk, we could probably save a bunch of time and memory by using the TermVectorMapper callback mechanism instead of materializing the full array of terms into memory and then throwing most of them out. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org