Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 20 Apr 2011 19:15:05 +0000 (UTC)
From: "Uwe Schindler (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1668561616.70780.1303326905708.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1194638679.70659.1303324745760.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (SOLR-2474) Analysis.jsp and
 AnalaysisRequestHandlerBase do not correctly clear attributes on caching
 tokens
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated SOLR-2474:
--------------------------------

    Description: 
When caching tokens, the helper TokenStreams in analysis.jsp and AnalysisRequestHandlerBase do not clear all attributes.
The issue is tricky. The cached tokens do not contain all attributes in early stages, so copyTo() does not necessarily overwrite all attributes in "this". Calling clearAttributes ensures this.

bq. Was: LUCENE-2901 broke protected words by only setting and never clearing (that change should have been accompanied by offsetting code to clear the attribute somewhere).

The problem here was, that this attribute was added later in anaylsis chain, so cached tokens don't include this. Sorry, that was my fault when rewriting analysis.jsp together with Robert :(

  was:LUCENE-2901 broke protected words by only setting and never clearing (that change should have been accompanied by offsetting code to clear the attribute somewhere).

        Summary: Analysis.jsp and AnalaysisRequestHandlerBase do not correctly clear attributes on caching tokens  (was: Aanalysis.jsp and AnalaysisRequestHandlerBase does not correctly clear attributes on caching tokens)

> Analysis.jsp and AnalaysisRequestHandlerBase do not correctly clear attributes on caching tokens
> ------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-2474
>                 URL: https://issues.apache.org/jira/browse/SOLR-2474
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Yonik Seeley
>            Assignee: Uwe Schindler
>         Attachments: SOLR-2474.patch
>
>
> When caching tokens, the helper TokenStreams in analysis.jsp and AnalysisRequestHandlerBase do not clear all attributes.
> The issue is tricky. The cached tokens do not contain all attributes in early stages, so copyTo() does not necessarily overwrite all attributes in "this". Calling clearAttributes ensures this.
> bq. Was: LUCENE-2901 broke protected words by only setting and never clearing (that change should have been accompanied by offsetting code to clear the attribute somewhere).
> The problem here was, that this attribute was added later in anaylsis chain, so cached tokens don't include this. Sorry, that was my fault when rewriting analysis.jsp together with Robert :(

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org