lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl <jan....@cominvent.com>
Subject Re: solr-3.1.0 bug/multicore
Date Mon, 18 Apr 2011 18:31:02 GMT
Atually, there is an issue https://issues.apache.org/jira/browse/SOLR-2333 already for this,
you can attach your patch to that one :)

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

On 18. apr. 2011, at 20.26, Jan Høydahl wrote:

> Hi,
> 
> Welcome to the Solr community, and thanks for contributing!
> 
> It's actually pretty easy to create a JIRA issue. First, register a new account in JIRA
and then create a new issue.
> 
> Here's a Wiki page helping you on the way: http://wiki.apache.org/solr/HowToContribute
> 
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com
> 
> On 18. apr. 2011, at 18.35, Rasmus Hahn wrote:
> 
>> Good Morning,
>> 
>> i noticed a small bug in your solr-3.1.0 release, but before you read any
>> further: This should really be a bug report, but i could not find any
>> possibility to submit a bug report into the jira
>> (https://issues.apache.org/jira/browse/SOLR). If the latter should be
>> possible, and someone can point me to a tutorial (best with screenshots)
>> on where to report bugs, do not hesitate and give me a pointer. Otherwise:
>> 
>> Phenomenon: in a multicore solr, when using the RENAME-action for two cores,
>> and a solr.xml with persistent='true', the renamed core, does not get its
>> name persisted in solr.xml; the old name is stored (only the solr.xml file
>> is wrong, the in-memory-cache is correct).
>> 
>> Reason: in org/apache/solr/core/CoreContainer.java, when persisting the
>> CoreContainer, solr-3.1.0 writes the values of the private cores-map
>> (solr-1.4.1 wrote the keys, too). To get the name of the core, the core's
>> CoreDescriptor is used, but for a RENAME, the core's descriptor is not being
>> updated.
>> 
>> Fix: i changed this in the register-function of the CoreContainer class,
>> since it is similar to the SWAP-operation that does a similar thing.
>> 
>> Patch:
>> (against https://svn.apache.org/repos/asf/lucene/dev/branches/lucene_solr_3_1)
>> 
>> Index: solr/src/java/org/apache/solr/core/CoreContainer.java
>> ===================================================================
>> --- solr/src/java/org/apache/solr/core/CoreContainer.java
>> (revision 1094545)
>> +++ solr/src/java/org/apache/solr/core/CoreContainer.java       (working copy)
>> @@ -381,7 +381,12 @@
>>    SolrCore old = null;
>>    synchronized (cores) {
>>      old = cores.put(name, core);
>> +      /*
>> +       * set both the name of the descriptor and the name of the
>> +       * core, since the descriptors name is used for persisting.
>> +       */
>>      core.setName(name);
>> +      core.getCoreDescriptor ().name = name;
>>    }
>> 
>> 
>> Best Regards - Rasmus
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message