lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2455) admin/index.jsp double submit on IE
Date Wed, 06 Apr 2011 07:17:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016281#comment-13016281
] 

Uwe Schindler commented on SOLR-2455:
-------------------------------------

Hi Jeffrey,

thaks for the fix. This is really an issue and has nothing to do with Internet Explorer. The
timing of the javascript calls in this browser just make it happen. In general: onclick handlers
in javascript *must* return false to prevent the default action. This is true in all browsers.
You can try this out with a simple web page link: <a href="gohere" onclick="window.alert('clicked');
return true;">..</a>. This link will first display the message box and then go to
"gohere" (in all browsers!), versus <a href="gohere" onclick="window.alert('clicked');
return false;">..</a> will only display the message box.

Another fix for this would be to simply remove form.submit() and explicitely return true.

> admin/index.jsp double submit on IE
> -----------------------------------
>
>                 Key: SOLR-2455
>                 URL: https://issues.apache.org/jira/browse/SOLR-2455
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.1
>         Environment: IE8
>            Reporter: Jeffrey Chang
>            Priority: Minor
>              Labels: patch
>         Attachments: SOLR-2455.patch, SOLR-2455.patch
>
>
> /admin/index.jsp could issue a double submit on IE causing Jetty to error out.
> Here are the steps to reproduce on IE8 (only applies to IE8 on occasional basis, really
more of an IE8 bug...):
> 1. Open IE8
> 2. Browse to http://localhost:8983/solr/admin
> 3. Submit a query
> 4. Displayed on Jetty log due to double submit:
> SEVERE: org.mortbay.jetty.EofException
>         at org.mortbay.jetty.HttpGenerator.flush(HttpGenerator.java:791)
>  
> This can be fixed easily by modifying index.jsp's javascript submit to return false:
> ... queryForm.submit(); return false; ...
> I will try to submit a patch for this easy fix, new to all this so please bear with me...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message