lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SOLR-2474) Analysis.jsp and AnalaysisRequestHandlerBase do not correctly clear attributes on caching tokens
Date Wed, 20 Apr 2011 21:36:06 GMT

     [ https://issues.apache.org/jira/browse/SOLR-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler resolved SOLR-2474.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.2

Committed 3.x revision: 1095519
Merged trunk revision: 1095521

Thanks Robert for investigating and Yonik for reporting this hairy one.

> Analysis.jsp and AnalaysisRequestHandlerBase do not correctly clear attributes on caching
tokens
> ------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-2474
>                 URL: https://issues.apache.org/jira/browse/SOLR-2474
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.1
>            Reporter: Yonik Seeley
>            Assignee: Uwe Schindler
>             Fix For: 3.2, 4.0
>
>         Attachments: SOLR-2474.patch
>
>
> When caching tokens, the helper TokenStreams in analysis.jsp and AnalysisRequestHandlerBase
do not clear all attributes.
> The issue is tricky. The cached tokens do not contain all attributes in early stages,
so copyTo() does not necessarily overwrite all attributes in "this". Calling clearAttributes
ensures this.
> bq. Was: LUCENE-2901 broke protected words by only setting and never clearing (that change
should have been accompanied by offsetting code to clear the attribute somewhere).
> The problem here was, that this attribute was added later in anaylsis chain, so cached
tokens don't include this. Sorry, that was my fault when rewriting analysis.jsp together with
Robert :(

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message