lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Busch (JIRA)" <>
Subject [jira] [Commented] (LUCENE-2956) Support updateDocument() with DWPTs
Date Tue, 12 Apr 2011 20:28:05 GMT


Michael Busch commented on LUCENE-2956:

Cool patch! :)
Though it worries me a little how complex the whole delete/update logic is becoming (not only
the part this patch adds).

Originally we decided to not go with sequenceIDs partly because we thought the implementation
might be too complex, but I think it'd be simpler than the current approach that uses bits.

The sequenceIDs approach we had in the beginning was also completely lockless in a very very
simple way.

Anyway, I have yet to take a closer look here. Just something that might be worth discussing.

> Support updateDocument() with DWPTs
> -----------------------------------
>                 Key: LUCENE-2956
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: Realtime Branch
>            Reporter: Michael Busch
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: Realtime Branch
>         Attachments: LUCENE-2956.patch
> With separate DocumentsWriterPerThreads (DWPT) it can currently happen that the delete
part of an updateDocument() is flushed and committed separately from the corresponding new
> We need to make sure that updateDocument() is always an atomic operation from a IW.commit()
and IW.getReader() perspective.  See LUCENE-2324 for more details.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message