Return-Path: Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: (qmail 20686 invoked from network); 27 Mar 2011 04:19:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Mar 2011 04:19:52 -0000 Received: (qmail 75007 invoked by uid 500); 27 Mar 2011 04:19:51 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 74886 invoked by uid 500); 27 Mar 2011 04:19:51 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 74879 invoked by uid 99); 27 Mar 2011 04:19:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Mar 2011 04:19:51 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of billnbell@gmail.com designates 209.85.214.176 as permitted sender) Received: from [209.85.214.176] (HELO mail-iw0-f176.google.com) (209.85.214.176) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Mar 2011 04:19:47 +0000 Received: by iwr19 with SMTP id 19so3516749iwr.35 for ; Sat, 26 Mar 2011 21:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=MySweJVLHR1BClCXbI3CuMdcb6kr2I/x3aczWrUkaX0=; b=GRiUbQVnQ2rME81g7eafAhZNUhjfJtWnFACyiwxb4jr6dxSNjerDd9UJ9kHobjZxCP YoB4Erxu32ftZGRQHsQ2FllBO7d0csNJETPc+vJb9gAuB4E2SEYv9t0W6694FSlc886U rfg3E+6wGq6ni62gYolSrOcDSemAgrBIhbJds= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=LzLf/7dlIr/FFtc5nNocVUWvZhYB3OFHd2/00DTvxBpczhZ0CsrIguWwX9HF4MgVP7 +kPwZyZsUVgJ6DXN872Mu0Wy6ZZSFPN09JyQ86497+Rlqvs5n3y1IHDU1CFRZxDpqXwU N2bwCX5Cafs3KBeLOCWV4uYpv3zrLHWdyf5ZA= MIME-Version: 1.0 Received: by 10.231.6.1 with SMTP id 1mr2572297ibx.24.1301199566331; Sat, 26 Mar 2011 21:19:26 -0700 (PDT) Received: by 10.231.34.77 with HTTP; Sat, 26 Mar 2011 21:19:26 -0700 (PDT) In-Reply-To: References: <504122126.13861.1301139125895.JavaMail.tomcat@hel.zones.apache.org> Date: Sat, 26 Mar 2011 22:19:26 -0600 Message-ID: Subject: Re: [jira] [Commented] (SOLR-2155) Geospatial search using geohash prefixes From: William Bell To: dev@lucene.apache.org Cc: Chris Male , yonik@lucidimagination.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Maybe I am too close to this issue and not looking at global implications like you are.... SOLR-2155 seems fairly close to "good to go". There are a couple open issues that David Smiley has been asking for input on. I would recommend we answer those questions, and commit it. Then we can look at modules, etc. If a rewrite was on the works, a committer should have said something a LONG time ago. Like back in October or something. Are we talking redesign or refactoring? I think core spatial things should remain in Lucene. Even though Spatial support in 3.1 is basic it is stable, and VERY fast. We ran regression tests and the performance was 10-100x faster than the plugin solution of Solr Spatial from Patrick. Whatever fancy support for polygons, etc we support it needs to be even faster than what we have with 3.1. What I like about this patch more than anything is the support for multiple-lat longs per document. I have several clients who need this feature. For example, one doctor with multiple offices. It would be nice if a committer would work with David Smiley to get this done. 1. We would like to know if the pole issue can be solved and how. 2. We would like to know the best way to support the multi lat long (without the copy happening) and get the values from multigeodist(). I have pushed up a good example, and I would like someone to please comment and maybe even show me some code to do that. There has been some discussions on this issue - my solution uses VS and it is fast. There might be faster and more simple ways to handle the N number of points. On another note, it is frustrating when David and I put in some time on this, and it sits out there with us "begging" for a committer to assist, and then when Grant starts discussions, it is summarility discarded with a new design without any input from the original contributors? Is this how we want to do things here? We should have Grant or Yonik work with David to get this patch done, Then we can discuss Spatial V2 and the design of it. Bill On Sat, Mar 26, 2011 at 7:19 PM, Chris Male wrote: > > > On Sun, Mar 27, 2011 at 7:30 AM, Yonik Seeley > wrote: >> >> On Sat, Mar 26, 2011 at 2:17 PM, Ryan McKinley wrote= : >> >>> >> >>> No, the question is: what justification is there for adding spatial >> >>> support to solr-only, leaving lucene with a broken contrib module, >> >>> versus adding it where it belongs and exposing it to solr? >> >> >> >> There need not be any linkage to lucene to improve a Solr feature. >> >> If you disagree, we should vote to clarify - this is too important >> >> (and too much of a negative for Solr). >> >> >> > >> > I don't think there is *requirement* to move the core spatial stuff to >> > lucene, but I think there is huge benefit to both communities if >> > things have as few dependencies as possible. =C2=A0To be frank, the sp= atial >> > support in solr is pretty hairy -- it works for some use cases, but is >> > not extendable and quite basic. =C2=A0Calling it 'distance' seems more >> > appropriate then 'spatial' >> >> >> Having something basic that works (and has a clean enough high level >> HTTP interface) was clearly a win for Solr users. >> >> Of course a more fully featured spatial module would be a win for >> everyone, but that's ignoring the more generic issue at hand here: >> a patch that improves Solr's spatial >> should not be blocked on the grounds that it does not improve Lucene's >> spatial enough. > > I don't think we need to see it that way, we want to improve both Solr an= d > Lucene's spatial support, not block either. =C2=A0As you say, having a mo= dule is > a win for everyone, Solr and Lucene alike, so it seems obvious that we > should go down that path and the code in SOLR-2155 would make a great fir= st > addition. > >> >> Likewise, the ridiculous notion that "Queries don't belong in Solr" >> needs to be put to rest. > > Issues in and around this seem to be coming up a lot these days (I'm > thinking FunctionQuerys too). =C2=A0Sounds like something that really doe= s need > to be openly discussed. > >> >> -Yonik >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org >> For additional commands, e-mail: dev-help@lucene.apache.org >> > > > > -- > Chris Male | Software Developer | JTeam BV.| www.jteam.nl > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org