lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Hostetter <hossman_luc...@fucit.org>
Subject Re: svn commit: r1085618 - /lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java
Date Wed, 30 Mar 2011 00:09:22 GMT


These messages are now logged on every request, even if no transformer or 
globs are used in the fl.

seems like this should be a DEBUG message at best?

if folks really think it's important to log this on every request, then 
shouldn't these three key=val pairs just be factored into the main request 
log message SolrCore does?  (by adding them to 
SolrQueryResponse.getToLog())

	?


: Date: Sat, 26 Mar 2011 00:44:10 -0000
: From: ryan@apache.org
: Reply-To: dev@lucene.apache.org
: To: commits@lucene.apache.org
: Subject: svn commit: r1085618 -
:     /lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java
: 
: Author: ryan
: Date: Sat Mar 26 00:44:10 2011
: New Revision: 1085618
: 
: URL: http://svn.apache.org/viewvc?rev=1085618&view=rev
: Log:
: remove nocommit from log message
: 
: Modified:
:     lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java
: 
: Modified: lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java
: URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java?rev=1085618&r1=1085617&r2=1085618&view=diff
: ==============================================================================
: --- lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java (original)
: +++ lucene/dev/trunk/solr/src/java/org/apache/solr/search/ReturnFields.java Sat Mar 26 00:44:10
2011
: @@ -97,12 +97,12 @@ public class ReturnFields
:          parseFieldList( new String[]{fl}, req);
:        }
:      }
: -    req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t transformer="+transformer);
 // nocommit
: +    req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t transformer="+transformer);
 
:    }
:  
:    public ReturnFields(String[] fl, SolrQueryRequest req) {
:      parseFieldList(fl, req);
: -    req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t transformer="+transformer);
 // nocommit
: +    req.getCore().log.info("fields=" + fields + "\t globs="+globs + "\t transformer="+transformer);
 
:    }
:  
:    private void parseFieldList(String[] fl, SolrQueryRequest req) {
: 
: 
: 

-Hoss

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message