lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan McKinley <ryan...@gmail.com>
Subject Re: extends LuceneTestCase, avoid preflex codec?
Date Wed, 30 Mar 2011 20:40:33 GMT
dooh -- yes, logic was backwards.

Thank you random testing!  (and Robert -- of course)


On Wed, Mar 30, 2011 at 4:32 PM, Robert Muir <rcmuir@gmail.com> wrote:
> On Wed, Mar 30, 2011 at 4:22 PM, Ryan McKinley <ryantxu@gmail.com> wrote:
>>            int off = ref.offset;
> ...
>>              if (off + buf.length > ref.length) {
>>                throw new InvalidShapeException("Asking for too many bytes");
>
> this check looks like it might be wrong (backwards logic) especially
> if the codec returns terms with nonzero bytesref offsets?
> but its hard to tell in the context of your small snippet...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message