lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (JIRA)" <>
Subject [jira] Updated: (LUCENE-2958) WriteLineDocTask improvements
Date Sun, 13 Mar 2011 19:57:59 GMT


Doron Cohen updated LUCENE-2958:

    Attachment: LUCENE-2958.patch

bq. Will that be simpler?
It will be simpler, I admit, but it will harder to manage:
* when re-reading the input file (with repeat=true) special treatment of the header line is
needed. And cannot assume that the header line exists, because there are 1-line files out
there without this line, which, is possible, I would not like to force recreating, and it
is possible.
* the simple LDS as today handles no header line. As such, if there is one, it will wrongly
treat it as a regular line. But I would like it to be able to handle both old files (with
no header) and new files, with the header. Mmmm,,, e could for that write the header only
if it differs from the default header. Perhaps this will work.

I'll take a look at that again, meanwhile attaching updated patch with the two inner DocDataLineReader's.

> WriteLineDocTask improvements
> -----------------------------
>                 Key: LUCENE-2958
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message