lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-2980) Benchmark's ContentSource should not rely on file suffixes to be lower cased when detecting file type (gzip/bzip2/text)
Date Wed, 23 Mar 2011 04:01:05 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009986#comment-13009986
] 

Shai Erera commented on LUCENE-2980:
------------------------------------

That's a serious problem - good catch !

Patch looks good. Perhaps we should add a specific test in CSTest for this problem? I wouldn't
use file.delete() as in indicator because on Linux it will pass. Perhaps a test which writes
to a byte[] and then an extension of ByteArrayInputStream would mark whether close() was called
and the test would assert on it.

> Benchmark's ContentSource should not rely on file suffixes to be lower cased when detecting
file type (gzip/bzip2/text)
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2980
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2980
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2980.patch, LUCENE-2980.patch
>
>
> file.gz is correctly handled as gzip, but file.GZ handled as text which is wrong.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message