lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-2966) SegmentReader.doCommit should be sync'd; norms methods need not be sync'd
Date Sat, 12 Mar 2011 23:06:59 GMT
SegmentReader.doCommit should be sync'd; norms methods need not be sync'd
-------------------------------------------------------------------------

                 Key: LUCENE-2966
                 URL: https://issues.apache.org/jira/browse/LUCENE-2966
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Michael McCandless
            Assignee: Michael McCandless
             Fix For: 3.1, 4.0
         Attachments: LUCENE-2966.patch

I fixed the failure in TestNRTThreads, but in the process tripped an assert because SegmentReader.doCommit
isn't sync'd.

So I sync'd it, but I don't think the norms APIs need to be sync'd -- we populate norms up
front and then never change them.  Un-sync'ing them is important so that in the NRT case calling
IW.commit doesn't block searches trying to pull norms.

Also some small code refactoring.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message