lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2338) improved per-field similarity integration into schema.xml
Date Wed, 30 Mar 2011 20:08:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013618#comment-13013618
] 

Hoss Man commented on SOLR-2338:
--------------------------------

i was confused by some of roberts comments, and clarified them with him on IRC.

summary (from my perspective)

* "global default" similarity(factory) (using existing {{<similarity/>}} tag) is a good
idea as a fall back for fieldTypes that don't define custom similarity
* {{<similarity/>}} should probably not be advertised in the example configs .. but
maybe, depends
* SimilarityProvider should use a distinct config tag ({{<similarityProvider/>}} because
it really is distinct, and people should (in theory) be able to use both)
* SolrSimilarityProvider's get(field) method (which i didn't realize was final, hence part
of my confusion) should be changed to use the {{<similarity/>}} as a default if it was
specified.
* SolrSimilarityProvider's get(field) method really needs to stay final, and should have docs
explain why (consistency with schema)
* SimilarityProviderFactory.init can be changed to using NamedList, but the docs should warn
people about the possibility of performance penalties for using it directly in their SolrSimilarityProvider


> improved per-field similarity integration into schema.xml
> ---------------------------------------------------------
>
>                 Key: SOLR-2338
>                 URL: https://issues.apache.org/jira/browse/SOLR-2338
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>         Attachments: SOLR-2338.patch, SOLR-2338.patch
>
>
> Currently since LUCENE-2236, we can enable Similarity per-field, but in schema.xml there
is only a 'global' factory
> for the SimilarityProvider.
> In my opinion this is too low-level because to customize Similarity on a per-field basis,
you have to set your own
> CustomSimilarityProvider with <similarity class=.../> and manage the per-field
mapping yourself in java code.
> Instead I think it would be better if you just specify the Similarity in the FieldType,
like after <analyzer>.
> As far as the example, one idea from LUCENE-1360 was to make a "short_text" or "metadata_text"
used by the
> various metadata fields in the example that has better norm quantization for its shortness...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message