lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-2986) divorce defaultsimilarityprovider from defaultsimilarity
Date Thu, 24 Mar 2011 13:47:05 GMT


Robert Muir commented on LUCENE-2986:

Thanks, I agree the tests look messy/lazy... I'll fix these (well I think I would like to
delay the solr one until SOLR-2338, i fixed the MockConfigurableSimilarity in that patch already)

> divorce defaultsimilarityprovider from defaultsimilarity
> --------------------------------------------------------
>                 Key: LUCENE-2986
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 4.0
>         Attachments: LUCENE-2986.patch
> In LUCENE-2236 as a start, we made DefaultSimilarity which implements the factory interface
(SimilarityProvider), and also extends Similarity.
> Its factory interface just returns itself always by default.
> Doron mentioned it would be cleaner to split the two, and I thought it would be good
to revisit it later.
> Today as I was looking at SOLR-2338, it became pretty clear that we should do this, it
makes things a lot cleaner. I think currently its confusing to users to see the two apis mixed
if they are trying to subclass.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message