lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Elschot (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode
Date Wed, 16 Mar 2011 08:27:29 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Elschot updated LUCENE-2945:
---------------------------------

    Attachment: LUCENE-2945d.patch

Basically the 2945d patch of 16 March 2011 is a refactoring of the 2945c patch. The static
inner classes have been moved to package private classes, and their common function was moved
to a new super class.

Also a few more test cases were added. Test cases for testing not equals might be still be
added, but I don't see a real need to do that.

As this adds handling equals/hashcode and has hardly any redundancy, I think this is committable.


> Surround Query doesn't properly handle equals/hashcode
> ------------------------------------------------------
>
>                 Key: LUCENE-2945
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2945
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0.3, 3.1, 4.0
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.1.1, 4.0
>
>         Attachments: LUCENE-2945-partial1.patch, LUCENE-2945.patch, LUCENE-2945.patch,
LUCENE-2945.patch, LUCENE-2945c.patch, LUCENE-2945d.patch
>
>
> In looking at using the surround queries with Solr, I am hitting issues caused by collisions
due to equals/hashcode not being implemented on the anonymous inner classes that are created
by things like DistanceQuery (branch 3.x, near line 76)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message