lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Commented] (SOLR-2415) Change XMLWriter version parameter to "wt.xml.version"
Date Wed, 23 Mar 2011 19:26:06 GMT


Hoss Man commented on SOLR-2415:

bq. how should we handle the desire to change the faceting format (to make it easier to add
metadata like total number of constraints, etc)? "version" would be one way. "facet.format"
would be another way.

i don't think the *structure* of the response (ie: the facet response section) should be driven
by the same param as the *format* of the response, which is what "version" currently is. 
Something like facet.format seems more appropriate when dealing with a specific component
like that ... but i don't think it should be a numeric "version" equse property, i think it
should be descriptive (ie: "flat", vs "nested" or something)

bq. perhaps we should add a getVersion() parameter on SolrQueryRequest and have that used
across all components.

when i suggested we have a common wt.version param that all of the response writers could
use, i didn't mean to suggest that it should have a singular id space. my suggestion was that
the specific values specified for "version" or "wt.version" or whatever would only be meaningful
to the specific response writer used -- just as the current values of the version param that
the XMLResponseWriter uses are meaninless to the JSONResponseWriter.  the overlap would only
be in reusing the param name (in the same way that "q" is the common param name for the main
query, regardless of what query parser is specified by "defType")

bq. Look at how long the existing response writers have hung around in their current format,
independent of the version # changes (1.2, 1.3, 1.4, and now 3.1)

the version param of the XML response writer has never been in sync with the solr version,
it was never intended to be.  it's always been the version number of the xml format.

> Change XMLWriter version parameter to "wt.xml.version"
> ------------------------------------------------------
>                 Key: SOLR-2415
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Trivial
>             Fix For: 4.0
> The XMLWriter has a parameter called 'version'.  This controls some specifics about how
the XMLWriter works.  Using the parameter name 'version' made sense back when the XMLWriter
was the only option, but with all the various writers and different places where 'version'
makes sense, I think we should change this parameter name to "wt.xml.version" so that it specifically
refers to the XMLWriter.

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message