lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-2381) The included jetty server does not support UTF-8
Date Wed, 09 Mar 2011 15:01:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004584#comment-13004584
] 

Robert Muir commented on SOLR-2381:
-----------------------------------

Bernd, i didn't test your jars, but can you update the patch on http://jira.codehaus.org/browse/JETTY-1340
with your fixes?

As an open source project, we can't just commit the binary jars.

I did however, test Uwe's patch. I think we should fix this bug in jetty, but I think we should
also use Uwe's patch (my random test passes always with his patch).

This jetty writer is hardly fast, i think it makes sense to try to bypass this "optimization"
in jetty which only causes bugs and likely only makes things slower actually (for example
lots of conditionals and state-keeping, Character.isLowSurrogate on every char, and handling
silly 6-byte UTF-8 cases which do not exist).

Its also a good safety net, I don't trust these servlet containers to do this correctly.

> The included jetty server does not support UTF-8
> ------------------------------------------------
>
>                 Key: SOLR-2381
>                 URL: https://issues.apache.org/jira/browse/SOLR-2381
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Blocker
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2381.patch, SOLR-2381_xmltest.patch, SOLR-ServletOutputWriter.patch,
jetty-6.1.26-patched-JETTY-1340.jar, jetty-6.1.26-patched-SOLR-2381.jar, jetty-util-6.1.26-patched-JETTY-1340.jar,
jetty-util-6.1.26-patched-SOLR-2381.jar, post_utf8enhanced.sh, utf8enhanced.xml
>
>
> Some background here: http://www.lucidimagination.com/search/document/6babe83bd4a98b64/which_unicode_version_is_supported_with_lucene
> Some possible solutions:
> * wait and see if we get resolution on http://jira.codehaus.org/browse/JETTY-1340. To
be honest, I am not even sure where jetty is being maintained (there is a separate jetty project
at eclipse.org with another bugtracker, but the older releases are at codehaus).
> * include a patched version of jetty with correct utf-8, using that patch.
> * remove jetty and include a different container instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message