lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-2958) WriteLineDocTask improvements
Date Mon, 14 Mar 2011 10:40:29 GMT


Michael McCandless commented on LUCENE-2958:

Patch looks great!  Some small things:

  * I think we should throw an exc if any of the field names contain
    the SEP char?

  * Can we name it "parseLine" instead of "readLine"?  Ie, the line
    has already been read (from the file); what remains is to parse it
    (and, as a side effect, change DocData to reflect that parsing).

  * Typo: sedDocData -> setDocData (in HeaderDocDataLineReader).

I do think we should move to all line files having the field header
line (w/ back compat handled for existing line files out there).  The
approach in the patch looks great -- the [common] fixed case of just
title/date/body that we have today is specialized and should still be
fast (SimpleDocDataLineReader).

> WriteLineDocTask improvements
> -----------------------------
>                 Key: LUCENE-2958
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>         Attachments: LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch, LUCENE-2958.patch
> Make WriteLineDocTask and LineDocSource more flexible/extendable:
> * allow to emit lines also for empty docs (keep current behavior as default)
> * allow more/less/other fields

This message is automatically generated by JIRA.
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message